OffTarget

Observed issues › catalog/cce-c-motion-iterator-rejected

Appears not to supportRefused at compile time · C · OpenMP · Open

craycc/ftn: OpenMP 5.1/5.2/6.0 forms HPE does not claim are rejected, and some crash the compiler instead of a diagnostic

Legality: not independently confirmed. no independent review yet How this is checked

Same issue as catalog/cce-c-map-iterator-ice; this program is another reproducer of it.

Affected variants

CompilerMI300A gfx942
unified memory (XNACK 1)
MI300A gfx942
copy (XNACK 0)
MI250X gfx90a
copy (XNACK 0)
MI300X gfx942
copy (XNACK 0)
MI350X gfx950
copy (XNACK 0)
A100 sm_80
separate memory
A100 sm_80
managed memory
AFAR 24.3.0correctfails another wayfails another wayfails another wayfails another wayn/an/a
CCE 19.0.0not supportednot supportednot supportedunknown
not run
unknown
not run
n/an/a
CCE 20.0.2not supportednot supportednot supportedunknown
not run
unknown
not run
n/an/a
CCE 21.0.3not supportednot supportednot supportedunknown
not run
unknown
not run
n/an/a
CCE 21.0.4not supportednot supportednot supportedunknown
not run
unknown
not run
n/an/a
NVHPC 25.11n/an/an/an/an/afails another wayfails another way
NVHPC 26.9n/an/an/an/an/afails another wayfails another way
GCC 16.2.0correctcorrectcorrectcorrectcorrectcorrectn/a

"behaves incorrectly" / "not supported": this issue, confirmed in up to four environments (another build directory, another node, a repeat). "fails another way": a different failure, not counted as this issue. "unknown": not run there, or the runs disagree.

Messages

ResultCompiler and GPUMessage
not supportedCCE 19.0.0, MI300A unified
CCE 19.0.0, MI300A copy
CCE 19.0.0, MI250X
CCE 20.0.2, MI300A unified
CCE 20.0.2, MI300A copy
CCE 20.0.2, MI250X
CCE 21.0.3, MI300A unified
CCE 21.0.3, MI300A copy
CCE 21.0.3, MI250X
CCE 21.0.4, MI300A unified
CCE 21.0.4, MI300A copy
CCE 21.0.4, MI250X
show
cce-c-motion-iterator-rejected.c:32:34: error: call to undeclared function 'iterator'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
   32 |   #pragma omp target update from(iterator(k = 1:2): b[k - 1:n - k + 1])
      |                                  ^
cce-c-motion-iterator-rejected.c:32:48: error: expected ')'
   32 |   #pragma omp target update from(iterator(k = 1:2): b[k - 1:n - k + 1])
      |                                                ^
cce-c-motion-iterator-rejected.c:32:42: note: to match this '('
   32 |   #pragma omp target update from(iterator(k = 1:2): b[k - 1:n - k + 1])
fails another wayAFAR 24.3.0, MI300A copy
AFAR 24.3.0, MI250X
AFAR 24.3.0, MI300X
AFAR 24.3.0, MI350X
show
RESULT ran_on_host=0 check=fail
fails another wayNVHPC 25.11, A100 separate
NVHPC 25.11, A100 managed
NVHPC 26.9, A100 separate
NVHPC 26.9, A100 managed
show
"cce-c-motion-iterator-rejected.c", line 32: error: identifier "iterator" is undefined
    #pragma omp target update from(iterator(k = 1:2): b[k - 1:n - k + 1])
                                   ^
"cce-c-motion-iterator-rejected.c", line 32: error: invalid text in pragma
    #pragma omp target update from(iterator(k = 1:2): b[k - 1:n - k + 1])
                                           ^
"cce-c-motion-iterator-rejected.c", line 13: warning: variable "k" was declared but never referenced [declared_but_not_referenced]
    int k;

Reproduce

CCE 19.0.0, MI300A unified

module load cce/19.0.0 craype-accel-amd-gfx942 rocm/6.4.3
module unload cray-mpich
craycc -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx942 -fopenmp-version=52 -O2 repro.c -o repro
HSA_XNACK=1 OMP_TARGET_OFFLOAD=mandatory ./repro

CCE 20.0.2, MI300A unified

module load cce/20.0.2 craype-accel-amd-gfx942 rocm/6.4.3
module unload cray-mpich
craycc -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx942 -fopenmp-version=52 -O2 repro.c -o repro
HSA_XNACK=1 OMP_TARGET_OFFLOAD=mandatory ./repro

CCE 21.0.3, MI300A unified

module load cce/21.0.3 craype-accel-amd-gfx942 rocm/7.2.0
module unload cray-mpich
craycc -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx942 -fopenmp-version=52 -O2 repro.c -o repro
HSA_XNACK=1 OMP_TARGET_OFFLOAD=mandatory ./repro

CCE 21.0.4, MI300A unified

module load cce/21.0.4 craype-accel-amd-gfx942 rocm/7.2.0
module unload cray-mpich
craycc -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx942 -fopenmp-version=52 -O2 repro.c -o repro
HSA_XNACK=1 OMP_TARGET_OFFLOAD=mandatory ./repro

AFAR 24.3.0, MI300A unified (runs correctly)

$AFAR/bin/amdclang -fopenmp --offload-arch=gfx942 -fopenmp-version=52 -fopenmp-version=52 -O2 repro.c -o repro
HSA_XNACK=1 OMP_TARGET_OFFLOAD=mandatory ./repro
Program (63 lines)
// # Draft finding: omp52-c-clause-from-iterator on cce19
//
// - compiler: cce19
// - toolchain: cce19; arch: gfx942; machine: tuolumne; memory mode: unified; opt: -O2
// - program: catalog omp52-c-clause-from-iterator (c, version 52, sha256 a2f233574ec18e5d)
// - expected: None (None; )
// - actual: rejected  (diagnostic: <tmpdir>/omp52-c-clause-from-iterator.c:41:34: error: call to undeclared function 'iterator'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declarati)
// - verdict: compiler_bug by rule R11-compile-rejection: a legal program the compiler rejects with a diagnostic (or whose link fails on symbols the compiler's own code needs, or whose compile does not finish) while another compiler family compiles it
// - reason: 
// - citations: RUL-COMPILE-TIME (rulings.md)
// - legality: legal (legal by construction: offload.engine.gen / c_gen / acc_gen check every program against the catalog rules and the offload scope as it is built (no compiler))
// - witnesses: none
// - withdrawn: none
//
// Generated by compliance.c_gen (OpenMP 5.2, C11): the C port (offload.engine.f2c) of omp52-clause-from-iterator. Do not edit.
// id: omp52-c-clause-from-iterator
// primary atom: omp.clause.from.iterator
// legal: yes
// observable: yes
// ran_on_host: inside the target region of interest
// evidence: copy_mode_only
// needs: none
// std: c11
#include <stdio.h>
#include <stdbool.h>
#include <omp.h>

enum { n = 64 };

int main(void) {
  int a[n];
  int b[n];
  int ref[n];
  int host_flag;
  bool ok;
  int k;
  for (int i = 1; i <= n; i++) {
    a[i - 1] = i;
    b[i - 1] = 0;
    ref[i - 1] = 2 * (i + 10) + 1;
  }
  host_flag = 1;
  #pragma omp target enter data map(to: a) map(alloc: b)
  for (int i = 1; i <= n; i++) {
    a[i - 1] = a[i - 1] + 10;
  }
  #pragma omp target update to(a)
  #pragma omp target map(to: a) map(from: b) map(tofrom: host_flag)
  {
    host_flag = (omp_is_initial_device() ? 1 : 0);
    for (int i = 1; i <= n; i++) {
      b[i - 1] = 2 * a[i - 1] + 1;
    }
  }
  #pragma omp target update from(iterator(k = 1:2): b[k - 1:n - k + 1])
  #pragma omp target exit data map(release: a, b)
  bool t1_ = true;
  for (int k2_ = 0; k2_ < n; k2_++)
    t1_ = t1_ && (b[k2_] == ref[k2_]);
  ok = t1_;
  printf("RESULT ran_on_host=%d check=%s\n", host_flag, ok ? "pass" : "fail");
  return 0;
}

Source in the repository

Something to add? Dispute its legality · Report it fixed in a newer release · Report a mistake on this page

Expected and observed

Observed where it behaves incorrectly

cce-c-motion-iterator-rejected.c:32:34: error: call to undeclared function 'iterator'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
   32 |   #pragma omp target update from(iterator(k = 1:2): b[k - 1:n - k + 1])
      |                                  ^
cce-c-motion-iterator-rejected.c:32:48: error: expected ')'
   32 |   #pragma omp target update from(iterator(k = 1:2): b[k - 1:n - k + 1])
      |                                                ^
cce-c-motion-iterator-rejected.c:32:42: note: to match this '('
   32 |   #pragma omp target update from(iterator(k = 1:2): b[k - 1:n - k + 1])

What the specification requires

The specification text this program relies on and the compiler is expected to support.

The same requirement as the issue catalog/cce-c-map-iterator-ice.

OpenMP 5.2 §3.2.6 p.67 l.6-8

An iterator modifier is a unique, complex modifier that defines a set of iterators, each of which is an iterator-identifier and an associated set of values.

OpenMP 5.2 §5.8.3 p.151 l.13-14

A list item in a map clause may reference any iterator-identifier defined in its iterator modifier.

Evidence

Same compiler, one change

  • from(b[0:n]) without the iterator modifier: AFAR 24.3.0: correct; CCE 19.0.0: correct; CCE 20.0.2: correct; CCE 21.0.3: correct; CCE 21.0.4: correct
    Control program
    #include <stdio.h>
    #include <stdbool.h>
    #include <omp.h>
    
    enum { n = 64 };
    
    int main(void) {
      int a[n];
      int b[n];
      int ref[n];
      int host_flag;
      bool ok;
      int k;
      for (int i = 1; i <= n; i++) {
        a[i - 1] = i;
        b[i - 1] = 0;
        ref[i - 1] = 2 * (i + 10) + 1;
      }
      host_flag = 1;
      #pragma omp target enter data map(to: a) map(alloc: b)
      for (int i = 1; i <= n; i++) {
        a[i - 1] = a[i - 1] + 10;
      }
      #pragma omp target update to(a)
      #pragma omp target map(to: a) map(from: b) map(tofrom: host_flag)
      {
        host_flag = (omp_is_initial_device() ? 1 : 0);
        for (int i = 1; i <= n; i++) {
          b[i - 1] = 2 * a[i - 1] + 1;
        }
      }
      #pragma omp target update from(b[0:n])
      #pragma omp target exit data map(release: a, b)
      bool t1_ = true;
      for (int k2_ = 0; k2_ < n; k2_++)
        t1_ = t1_ && (b[k2_] == ref[k2_]);
      ok = t1_;
      printf("RESULT ran_on_host=%d check=%s\n", host_flag, ok ? "pass" : "fail");
      return 0;
    }
    

Other compilers run it correctly

AFAR 24.3.0, GCC 16.2.0