amdflang/amdclang: a named critical (Fortran) or a critical with hint (C) in a target region fails at the device link (__kmpc_critical_with_hint undefined)

// # Draft finding: omp52-c-w-critical-hint on afar
//
// - compiler: afar
// - toolchain: afar; arch: gfx942; machine: tuolumne; memory mode: unified; opt: -O2
// - program: catalog omp52-c-w-critical-hint (c, version 52, sha256 27f075f0e726545a)
// - expected: None (None; )
// - actual: rejected  (link_undefined_symbol: ld.lld: error: undefined symbol: __kmpc_critical_with_hint)
// - verdict: compiler_bug by rule R10b-own-link-or-hang: a link failure on symbols the compiler's own generated code needs, or a compile that does not finish, on a legal program: the compiler's defect (never a rejection)
// - reason: 
// - citations: RUL-COMPILE-TIME (rulings.md)
// - legality: legal: offload.engine.rules accepts it (offload.engine.prerun.check, rerun: with the
//   race rule and the restriction checks); NVHPC is no witness: it does not implement a feature
//   the program uses (NVC++-F-1196-OpenMP - omp critical is not supported in GPU region);
//   the check's other witness, the AFAR clang front end, is the compiler under test and is not
//   counted; no gfortran or gcc is a legality witness
// - witnesses: none
// - withdrawn: none
//
// Generated by compliance.widen (OpenMP 5.2, C11; catalog widening). Do not edit.
// id: omp52-c-w-critical-hint
// primary atom: omp.clause.hint
// atoms: omp.clause.hint
// legal: yes
// observable: yes
// ran_on_host: inside the target region of interest
// evidence: construct
// needs: none
// std: c11
// feature: a named critical construct with a hint clause in a target parallel loop
// spec: OpenMP 5.2 §15.2, p.299 (critical construct); its binding thread set is the contention group, so a target parallel region (one team) is used; §15.1 (hint clause)
#include <stdio.h>
#include <stdbool.h>
#include <omp.h>

enum { n = 64 };

int main(void) {
  int a[n], b[n], ref[n];
  int host_flag = 1;
  int s = 0;
  for (int i = 0; i < n; i++) {
    a[i] = i + 1;
    b[i] = 0;
    ref[i] = 0;
  }
  #pragma omp target parallel for map(to: a) map(tofrom: s, host_flag)
  for (int i = 0; i < n; i++) {
    #pragma omp critical(wsum) hint(omp_sync_hint_contended)
    {
      int t = s;
      s = t + a[i];
    }
    if (i == 0) host_flag = omp_is_initial_device();
  }
  bool ok = true;
  for (int i = 0; i < n; i++)
    ok = ok && (b[i] == ref[i]);
  ok = ok && (s == n * (n + 1) / 2);
  printf("RESULT ran_on_host=%d check=%s\n", host_flag, ok ? "pass" : "fail");
  return 0;
}